Feature template picker #993

rolson · 2024-12-28T00:44:45Z

We have one of these in the objc toolkit.

This is an initial PR. I still need to add tests and a tutorial. Also the map that I use in the example is not a good map for this. I need to find a better map.

Re-enable `FeatureFormViewTests/testCase_7_1`

Re-enable `FeatureFormViewTests/testCase_3_6`

`FeatureFormView` / `ComboBoxInput` - Show unsupported values

`FeatureFormView`/`InputFooter` - Handle all possible numeric domain field types

…ew.swift Co-authored-by: David Feinzimer <[email protected]>

Support `TextFormElement`s inside a `GroupFormElement`

…neView.swift Co-authored-by: Destiny Hochhalter <[email protected]>

`FeatureFormView` - 200.6 doc updates

#937 (comment)

Prevents crashing

[Update] Table top `translationFactor` doc

mhdostal · 2025-01-03T17:22:01Z

Ok, I fixed the image size so that it will limit it to 50x50, but not enlarge the smaller icon sizes.

The only issue I see with that is when Dynamic Type is used the text will increase in size but not the icons. That would be "nice-to-have", but it's not a dealbreaker for me.

I did add padding around the image to keep the size in check.

Image(uiImage: image)
    .resizable()
    .aspectRatio(contentMode: .fit)
    .padding(4)

Here's what it looks like with Dynamic Type:

And without it:

rolson · 2025-01-03T17:31:00Z

The only issue I see with that is when Dynamic Type is used the text will increase in size but not the icons. That would be "nice-to-have", but it's not a dealbreaker for me.

I'd rather have features that are under 50x50 draw correctly in their correct size. To me that's important. If there is a way to do that and let the larger features grow up to the dynamic font size, that would be ideal. But I couldn't find a way to do that unfortunately.

philium · 2025-01-03T17:44:04Z

The tool for that job is ScaledMetric.

Sources/ArcGISToolkit/Components/FeatureTemplatePicker/FeatureTemplatePicker.swift

...s/ArcGISToolkit/Documentation.docc/Resources/FeatureTemplatePicker/FeatureTemplatePicker.png

Sources/ArcGISToolkit/Documentation.docc/Tutorials/FeatureTemplatePickerTutorial.tutorial

Tests/ArcGISToolkitTests/FeatureTemplatePickerTests.swift

…latePickerTutorial.tutorial Co-authored-by: David Feinzimer <[email protected]>

…arcgis-maps-sdk-swift-toolkit into ryan/featureTemplatePicker

dfeinzimer

Just 2 last comments and I think that'll be it.

dfeinzimer · 2025-01-04T00:24:32Z

Sources/ArcGISToolkit/Components/FeatureTemplatePicker/FeatureTemplatePicker.swift

+                    )
+                }


Should the templates be sorted alphabetically by name?

Suggested change

)

}

)

infos.sort { $0.template.name < $1.template.name }

}

Perhaps the sections too?

I'm not sure. I could see alphabetizing them. Currently it is in the order of layers and then the templates that the layers report. So I'm not sure what is desirable. @mhdostal do you recall what the obj-c based version did?

I'm not sure. I could see alphabetizing them. Currently it is in the order of layers and then the templates that the layers report. So I'm not sure what is desirable. @mhdostal do you recall what the obj-c based version did?

There was no sorting in the obj-c template picker.

...s/ArcGISToolkit/Documentation.docc/Resources/FeatureTemplatePicker/FeatureTemplatePicker.png

mhdostal · 2025-01-06T19:59:52Z

One enhancement request would be to only show the templates that apply to a specific geometry type. In the Swft FF test app, we are only allowing creating point symbols, so limiting the feature templates to those supporting point geometries would be nice.

rolson · 2025-01-07T23:19:24Z

One enhancement request would be to only show the templates that apply to a specific geometry type. In the Swft FF test app, we are only allowing creating point symbols, so limiting the feature templates to those supporting point geometries would be nice.

Cool. Did the original template picker in the other toolkit do this as well?

mhdostal · 2025-01-07T23:25:57Z

One enhancement request would be to only show the templates that apply to a specific geometry type. In the Swft FF test app, we are only allowing creating point symbols, so limiting the feature templates to those supporting point geometries would be nice.

Cool. Did the original template picker in the other toolkit do this as well?

No, but it's something that I'm doing for the Swift Feature Form test app; we're not concerned with the full geometry-editing experience yet, so we're only supporting adding point features.

dfeinzimer

Updated the image. PR looks good 👍

Sources/ArcGISToolkit/Components/FeatureTemplatePicker/FeatureTemplatePicker.swift

…TemplatePicker.swift

dfeinzimer and others added 30 commits October 24, 2024 13:15

Update ComboBoxInput.swift

74fe137

Update Localizable.strings

6d1f095

Merge pull request #930 from Esri/df/apollo/927

de56527

Re-enable `FeatureFormViewTests/testCase_7_1`

Merge branch 'v.next' into pr/922

919a367

Don't treat an empty value as an unsupported value

c3a45c4

Add FeatureFormTestView/testCase_3_7

46bddb8

Update impl

0ab62ed

Update ComboBoxInput.swift

892f8db

Update FormViewTests.swift

b5e4876

Merge pull request #933 from Esri/df/apollo/927_3.6

fb01b11

Re-enable `FeatureFormViewTests/testCase_3_6`

Merge pull request #922 from Esri/df/apollo/839

69dbe3d

`FeatureFormView` / `ComboBoxInput` - Show unsupported values

Handle Int16

efa20a4

Support more than just FieldFormElements in GroupElements

3a70c07

Update api doc.

77f3726

Update InputFooter.swift

d23da01

Update InputFooter.swift

9522454

Merge pull request #935 from Esri/df/apollo/802

2ddad22

`FeatureFormView`/`InputFooter` - Handle all possible numeric domain field types

Update Sources/ArcGISToolkit/Components/FeatureFormView/FeatureFormVi…

b6539e2

…ew.swift Co-authored-by: David Feinzimer <[email protected]>

Update Sources/ArcGISToolkit/Components/FeatureFormView/FeatureFormVi…

a0c5b4c

…ew.swift Co-authored-by: David Feinzimer <[email protected]>

Merge pull request #934 from Esri/mhd/GroupElement_TextElement

4fb42ff

Support `TextFormElement`s inside a `GroupFormElement`

Update Sources/ArcGISToolkit/Components/Augmented Reality/TableTopSce…

7bd3c2a

…neView.swift Co-authored-by: Destiny Hochhalter <[email protected]>

Revise doc for 200.6

96db2d3

Merge pull request #938 from Esri/df/apollo/922

daff34c

`FeatureFormView` - 200.6 doc updates

Update tutorial.

c4e079d

#937 (comment)

Add value descriptions.

dcc38ba

#937 (comment)

Add support for soft breaks

87d6f77

Support unsupported markdown elements

fa8233c

Prevents crashing

Update MarkdownView.swift

cf8817b

Merge pull request #937 from Esri/Caleb/Update-TranslationFactorDoc

b52af57

[Update] Table top `translationFactor` doc

Add visionOS support to PopupView

6b4cf59

mhdostal requested changes Jan 3, 2025

View reviewed changes

Sources/ArcGISToolkit/Components/FeatureTemplatePicker/FeatureTemplatePicker.swift Show resolved Hide resolved

Sources/ArcGISToolkit/Components/FeatureTemplatePicker/FeatureTemplatePicker.swift Outdated Show resolved Hide resolved

fix issues with maximum size

ecbcb54

rolson force-pushed the ryan/featureTemplatePicker branch from 32af9db to 3ffb37d Compare January 3, 2025 20:46

add PR feedback

1fc280f

dfeinzimer reviewed Jan 3, 2025

View reviewed changes

rolson and others added 4 commits January 3, 2025 14:39

Update Sources/ArcGISToolkit/Documentation.docc/Tutorials/FeatureTemp…

3e31094

…latePickerTutorial.tutorial Co-authored-by: David Feinzimer <[email protected]>

implement solution for iOS 16

18873ec

Merge branch 'ryan/featureTemplatePicker' of https://github.com/Esri/…

196a718

…arcgis-maps-sdk-swift-toolkit into ryan/featureTemplatePicker

fix warnings

b486895

rolson requested review from mhdostal and dfeinzimer January 3, 2025 21:58

dfeinzimer reviewed Jan 4, 2025

View reviewed changes

mhdostal previously approved these changes Jan 6, 2025

View reviewed changes

Update FeatureTemplatePicker.png

4ef1307

dfeinzimer dismissed mhdostal’s stale review via 57aef47 January 7, 2025 23:48

dfeinzimer previously approved these changes Jan 7, 2025

View reviewed changes

rolson commented Jan 15, 2025

View reviewed changes

Sources/ArcGISToolkit/Components/FeatureTemplatePicker/FeatureTemplatePicker.swift Outdated Show resolved Hide resolved

Update Sources/ArcGISToolkit/Components/FeatureTemplatePicker/Feature…

02ebdcf

…TemplatePicker.swift

rolson dismissed dfeinzimer’s stale review via 5f2f894 January 15, 2025 00:10

mhdostal previously approved these changes Jan 15, 2025

View reviewed changes

dfeinzimer previously approved these changes Mar 10, 2025

View reviewed changes

mhdostal dismissed stale reviews from dfeinzimer and themself via 02ebdcf May 22, 2025 21:49

mhdostal force-pushed the ryan/featureTemplatePicker branch from 5f2f894 to 02ebdcf Compare May 22, 2025 21:49

-                    )
-                }
+                    )
+                    infos.sort { $0.template.name < $1.template.name }
+                }

Feature template picker #993

Are you sure you want to change the base?

Feature template picker #993

Uh oh!

Conversation

rolson commented Dec 28, 2024

Uh oh!

mhdostal commented Jan 3, 2025

Uh oh!

rolson commented Jan 3, 2025

Uh oh!

philium commented Jan 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dfeinzimer left a comment

Choose a reason for hiding this comment

Uh oh!

dfeinzimer Jan 4, 2025

Choose a reason for hiding this comment

Uh oh!

dfeinzimer Jan 4, 2025

Choose a reason for hiding this comment

Uh oh!

rolson Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

mhdostal Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mhdostal commented Jan 6, 2025

Uh oh!

rolson commented Jan 7, 2025

Uh oh!

mhdostal commented Jan 7, 2025

Uh oh!

dfeinzimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!